search

qiskit-community / qiskit-dynamics

Tools for building and solving models of quantum systems in Qiskit
https://qiskit-community.github.io/qiskit-dynamics/
Apache License 2.0
105 stars 61 forks source link

Remove old test class TestJaxBase #328

Closed DanPuzzuoli closed 8 months ago

DanPuzzuoli commented 8 months ago

Summary

Details and comments

to24toro commented 8 months ago

Thanks Dan. This PR looks good for me. In addition, Can we remove ArrayTest class e.g. ArrayNumpyTestBase?

DanPuzzuoli commented 8 months ago

Thanks Dan. This PR looks good for me. In addition, Can we remove ArrayTest class e.g. ArrayNumpyTestBase?

That's a good question. We're currently using it for Signal testing, and I was thinking we could keep it there since we will be deprecating Array and not getting rid of it right away. On the other hand, the usage of Array throughout the package generally is already broken, so it may not be worth maintaining tests for the signal class. What do you think?

to24toro commented 8 months ago

Thanks. I consider that it is better to drop Array test cases at the same time that we will deprecate Array class.