search

qiskit-community / qiskit-dynamics

Tools for building and solving models of quantum systems in Qiskit
https://qiskit-community.github.io/qiskit-dynamics/
Apache License 2.0
105 stars 61 forks source link

Default t_span available for `DynamicsBackend.solve` #353

Closed arthurostrauss closed 6 months ago

arthurostrauss commented 7 months ago

Summary

This PR introduces the possibility to use DynamicsBackend.solve()without having to specify a t_spanargument explicitly. If it is not specified, the default t_spanis inferred from the provided solve_input to create a t_spanof the form [0, solve_input.duration] for each solve_input in the provided list. This can be useful for simulating easily a full QuantumCircuits as the process of converting them to Schedule is already done behind the scenes.

Details and comments

arthurostrauss commented 7 months ago

I'm not really sure why the tests are failing, they do not seem related to the proposed changes at all.

DanPuzzuoli commented 7 months ago

I'm not really sure why the tests are failing, they do not seem related to the proposed changes at all.

I think it may be due to the latest qutip update, which occurred after the last time the automated tests were run - I can look into it tomorrow.

DanPuzzuoli commented 7 months ago

Okay just merged a fix for the qutip qobj handling in #354 , you can try again after updating your branch.

arthurostrauss commented 7 months ago

@DanPuzzuoli Any updates on this?

DanPuzzuoli commented 7 months ago

@DanPuzzuoli Any updates on this?

Hey @arthurostrauss - if this is ready for review please request my review on the right :).

arthurostrauss commented 6 months ago

@DanPuzzuoli It seems I am not able to add any reviewers on the panel unfortunately (it indicates that I am not authorised to edit the PR). Can you assign yourself to the review?