qiskit-community / qiskit-experiments

Qiskit Experiments
https://qiskit-community.github.io/qiskit-experiments/
Apache License 2.0
160 stars 126 forks source link

Remove remaining code usage deprecated in Qiskit 0.46 #1384

Closed wshanks closed 9 months ago

wshanks commented 9 months ago

This change adjusts for several remaining changes in Qiskit 1.0:

Also, this change unpins qiskit which had to be pinned in f22bb7b67893a1b75f7d0f1fecdb0bd63284e244 until these fixes could be merged since 0.46.0 was released with deprecation warnings for some of the usage changed here.

wshanks commented 9 months ago

@coruscating This fixes the tests against Qiskit main which I noticed had started failing again.

wshanks commented 9 months ago

Maybe we should remove that now to try to get the cron tests working again.

I added a change for it. I think the cron tests will still fail because we need qiskit-ibm-runtime which still depends on qiskit-ibm-provider in its latest release and qiskit-ibm-provider is not compatible with qiskit 1.0. If we don't want to wait for qiskit-ibm-runtime, we might need to fork it, patch out the qiskit-ibm-provider part (sloppily since we just need the fake backends), and install from the fork until qiskit-ibm-runtime can properly remove the qiskit-ibm-provider parts.

I think we should deprecate BackendData.is_simulator. It is not used in the repo and I am not sure it is that useful to users. The online simulators are deprecated and besides that the user should be able to tell from context if a backend is a simulator (they won't be iterating over a list from a provider with a mix of simulators and hardware backends).