Closed wshanks closed 9 months ago
@coruscating This fixes the tests against Qiskit main which I noticed had started failing again.
Maybe we should remove that now to try to get the cron tests working again.
I added a change for it. I think the cron tests will still fail because we need qiskit-ibm-runtime which still depends on qiskit-ibm-provider in its latest release and qiskit-ibm-provider is not compatible with qiskit 1.0. If we don't want to wait for qiskit-ibm-runtime, we might need to fork it, patch out the qiskit-ibm-provider part (sloppily since we just need the fake backends), and install from the fork until qiskit-ibm-runtime can properly remove the qiskit-ibm-provider parts.
I think we should deprecate BackendData.is_simulator
. It is not used in the repo and I am not sure it is that useful to users. The online simulators are deprecated and besides that the user should be able to tell from context if a backend is a simulator (they won't be iterating over a list from a provider with a mix of simulators and hardware backends).
This change adjusts for several remaining changes in Qiskit 1.0:
qiskit.providers.basicaer was removed in Qiskit 1.0 (see https://github.com/Qiskit/qiskit/pull/11422). Here its use is replaced with qiskit-aer.
qiskit.providers.fake_provider.FakeJob
was removed in Qiskit 1.0 (see https://github.com/Qiskit/qiskit/pull/11376). Here theFakeJob
already inqiskit_experiments.test
is used instead. This update was missed in f22bb7b67893a1b75f7d0f1fecdb0bd63284e244 which switched the otherfake_provider
usage.Replace
qiskit.provider.FakeProvider
with a custom subclass ofProviderV1
.FakeProvider
was moved out of Qiskit 1.0 to qiskit-ibm-runtime.calibration/test_rabi.py
was modified to make the data for a test of bad data worse as the test started fitting the data as good with the original parameters and qiskit-aer in place of basicaer.In the readout mitigation manual, a use of
plot_histogram
was exchanged for one ofplot_distribution
.Guard
FakeBackendV2
import that was removed in Qiskit 1.0. Try to importFakeBackendV2
from qiskit-ibm-runtime as well.Also, this change unpins qiskit which had to be pinned in f22bb7b67893a1b75f7d0f1fecdb0bd63284e244 until these fixes could be merged since 0.46.0 was released with deprecation warnings for some of the usage changed here.