qiskit-community / qiskit-finance

Quantum Finance
https://qiskit-community.github.io/qiskit-finance/
Apache License 2.0
238 stars 134 forks source link

Fix Yahoo Data Provider unit test #309

Closed woodsp-ibm closed 12 months ago

woodsp-ibm commented 12 months ago

Summary

From time to time the yahoo data provider unit test fails as the values fetched no longer match the reference values they were before. Maybe the historical data is compressed occasionally with a single value covering a larger time period so the value is altered a little for the average over that new period. Whatever the reason the nightly CI has failed the last couple of times due to some change in the ref values. This updates them, as had been done in the past, so its not the first time its happened! Since this will break unit tests over in stable I marked it as backport to keep them running if needed.

Details and comments

I also added a comment in the code to note this since it does need updating periodically.

coveralls commented 12 months ago

Pull Request Test Coverage Report for Build 6914900347


Totals Coverage Status
Change from base Build 6868646405: 0.0%
Covered Lines: 646
Relevant Lines: 852

💛 - Coveralls