search

qiskit-community / qiskit-finance

Quantum Finance
https://qiskit-community.github.io/qiskit-finance/
Apache License 2.0
238 stars 134 forks source link

Fix CI for data provider change and cct draw #344

Closed woodsp-ibm closed 2 months ago

woodsp-ibm commented 2 months ago

Summary

Closes #343

Now that the Qiskit issue referenced in #343 has been released in 1.2.1 I have updated the failing data provider test reference values and also fixed the reference circuit draw output since that has changed too.

Details and comments

woodsp-ibm commented 2 months ago

It seems that one of the notebooks, which was failing before also with the bug introduced in Qiskit 1.2.0, ie. the _gates_to_uncompute method not being found, is now failing with a dead kernel. So I guess I'll have to take a look at that too.

woodsp-ibm commented 2 months ago

Having checked out the notebook failure it seems that its using Qiskit Aer and its Sampler and switching it to the Qiskit Sampler it works fine. I raised an issue on Aer that I linked in an issue here #345 to track things. Since this PR fixes the other problems rather than waiting for a fix (I had already been waiting sometime for the gates to uncompute fix to come out) I am going to merge this as-is.