search

qiskit-community / qiskit-ignis

Ignis (deprecated) provides tools for quantum hardware verification, noise characterization, and error correction.
Apache License 2.0
168 stars 162 forks source link

Fast analytical computation of SyndromeGraph for RepetitionCode #588

Closed daniel-miller-quantum closed 2 years ago

daniel-miller-quantum commented 2 years ago

Summary

Speed up computation of GraphDecoder Graph for RepetitionCodes using an analytical approach.

Details and comments

These changes do not impact any features of qiskit outside of ignis/verification/topological_codes.

quantumjim commented 2 years ago

Does some button need to be pushed somewhere so that this starts running the tests, etc? @mtreinish

ShellyGarion commented 2 years ago

Does some button need to be pushed somewhere so that this starts running the tests, etc? @mtreinish

There are some lint errors that should be fixed first: https://github.com/Qiskit/qiskit-ignis/pull/588/checks?check_run_id=3253483939

quantumjim commented 2 years ago

Thanks @ShellyGarion . The lint errors should be fixed now, but it still doesn't seem to automatically test.

ShellyGarion commented 2 years ago

I think that now we need the help of @mtreinish for that

mtreinish commented 2 years ago

oh, one other comment. I realize you (or more likely your IDE) probably just ran black on the code. But, all the unrelated code formatting changes in the PR made this a lot more difficult for me to review (because for every line in the diff I had to figure out whether it was just code formatting or part of the feature). In the future can you split those into 2 PRs, one for formatting changes and the other for the functionality? The code formatting will be easy to review as it's mechanical and that'll speed up reviews for functional changes too.

quantumjim commented 2 years ago

Thanks @mtreinish. I agree this is ready to go, and all the changes you propose look good to me.