search

qiskit-community / qiskit-ignis

Ignis (deprecated) provides tools for quantum hardware verification, noise characterization, and error correction.
Apache License 2.0
167 stars 160 forks source link

Don't include docs in discovered packages #611

Closed BastianZim closed 2 years ago

BastianZim commented 2 years ago

Summary

Currently, docs is included as a separate package. This pollutes the user environment when installing the package.

Details and comments

I have not added a changelog because it is such a small change. Let me know if I should.

BastianZim commented 2 years ago

I know this package is maintenance-only but I would need this downstream still. Thanks!

mtreinish commented 2 years ago

I know this package is maintenance-only but I would need this downstream still. Thanks!

It's probably the last chance for us to include this. I was just preparing to EoL the package next month (I've got the pieces started here https://github.com/Qiskit/qiskit/pull/1487 ). Do you need a bugfix release to include this or is merging it sufficient for your use case?

BastianZim commented 2 years ago

Thank you! Bugfix would be nice so that I can clean up the package downstream. I'm using this because I'm managing the distribution in conda-forge where I included the patch for now but a clean recipe would be nice for archiving everything. But if not possible, no worries.

BastianZim commented 2 years ago

Thank you!

mtreinish commented 2 years ago

I'll start preparing a 0.7.1 release it's low overhead to get it out to fix this. There might be some other last minute bugfixes we can include before we archive this project.

BastianZim commented 2 years ago

Awesome, thank you! :)