Indention bug in else statement of torch connector.

qiskit-community / qiskit-machine-learning

Quantum Machine Learning

https://qiskit-community.github.io/qiskit-machine-learning/

Apache License 2.0

647 stars 316 forks source link

Indention bug in else statement of torch connector. #105

Closed nonhermitian closed 3 years ago

nonhermitian commented 3 years ago

Information

Qiskit Machine Learning version:
Python version:
Operating system:

What is the current behavior?

There is an indentation error on line 166 of the torch connector.

Steps to reproduce the problem

What is the expected behavior?

Suggested solutions

adekusar-drl commented 3 years ago

@nonhermitian What is wrong with indentation in this code? Looks good to me.

nonhermitian commented 3 years ago

The issue originates from someone other than myself so I cannot say. However it seems that one of the statements is not nested at the correct level and causes issues when actually using the module.

adekusar-drl commented 3 years ago

Well, it is supposed to be an if - elif - else statement. So, it is unclear where indentation is wrong. Do you have any other details of the issue or know who originally raised this issue?

nonhermitian commented 3 years ago

Sorry they reported it a bit further down.

adekusar-drl commented 3 years ago

I see, the selected part looks good to me either. So, are there any actual problems with the torch connector e.g. wrong results?

nonhermitian commented 3 years ago

Please just close this issue. I will ask the original authors to post a new issue themselves.

adekusar-drl commented 3 years ago

OK, thanks.