qiskit-community / qiskit-machine-learning

Quantum Machine Learning
https://qiskit-community.github.io/qiskit-machine-learning/
Apache License 2.0
648 stars 316 forks source link

Add more classifier #492

Open poig opened 1 year ago

poig commented 1 year ago

What should we add?

we should include more classifiers:

Maybe we should add these also:

chin-jey commented 1 year ago

There's this project implementing other quantum classification and regression methods : https://github.com/mspronesti/qlearnkit

poig commented 1 year ago

Yeah, thanks for the share, it includes QKmeans, Qridge, QSVM K-NN, regression, dataset, encoding map, swaptest circuit, but it's not fit the latest qiskit version.

chin-jey commented 1 year ago

Why not ? It seems it does to me.

poig commented 1 year ago

Why not ? It seems it does to me.

thanks, I just see that it fit with the sources code, but not the latest release version.

adekusar-drl commented 1 year ago

For example, quantum KNN requires either access to quantum memory to keep the states handy or re-creation of states every time when a distance is evaluated. Thus, the quantum version of the algorithm does not bring any advantages over the classical version. I can't say the above mentioned algorithms suffer from the same problem, they have to be studied and evaluated if they can bring value for this package. If you want to develop one of them, and possibly to contribute them, we can discuss in more details.

edoaltamura commented 6 months ago

Hi @poig @chin-jey, have there been recent developments on this discussion? Feel free to post a simple example here, as it might be useful for others. Once we've seen an implementation, we can evaluate together if it's worth turning it into a PR.