Restore mypy checks on Windows and lowest Numpy version

qiskit-community / qiskit-machine-learning

Quantum Machine Learning

https://qiskit-community.github.io/qiskit-machine-learning/

Apache License 2.0

690 stars 327 forks source link

Restore mypy checks on Windows and lowest Numpy version #818

Closed edoaltamura closed 1 month ago

edoaltamura commented 4 months ago

What should we add?

Revert changes in https://github.com/qiskit-community/qiskit-machine-learning/pull/816:

.github/workflows/main.yml: delete && matrix.os != 'windows-latest' to restore mypy checks for Windows platform for PyTorch. This change depends on https://github.com/pytorch/pytorch/issues/124897 being resolved.
constraints.txt: numpy<2.0 -> numpy>=1.20.0 restore original constraint on Numpy version

edoaltamura commented 3 months ago

The issue in PyTorch was resolved in the 2.4 release, so this constraint will be released accordingly. After the release the tests will run with the latest Pytorch and a compatible Numpy install (usually >2.0).

edoaltamura commented 2 months ago

The UTF encoding issue is resolved but the Numpy still needs to be restricted to <2 when used with PyTorch as a workaround for Windows.