qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
289 stars 209 forks source link

Fix Q3d and Ansys render chip bounding box vs. full ground plane (Owner: Thomas) (Due: Feb 2) #203

Closed zlatko-minev closed 3 years ago

zlatko-minev commented 3 years ago

What is the feature being requested?

Fix Q3d and Ansys render chip bounding box vs. full ground plane image

What are use cases for this feature?

zlatko-minev commented 3 years ago

If everything is selected right now we draw full chip, but this needs to be a flag for user choice

ThomasGM4 commented 3 years ago

So I think this can be managed just by some tweaking of the current logic flow.

The previous manner where we did full chip if all components rendered, bounding box if only some components are rendered, can be dropped and just replaced with the above. Although the previous allowed some simplicity and streamline, we found enough occourences that were problematic that I think the above suggested approach is probably the best case to go with.

zlatko-minev commented 3 years ago

Thank you

Sent from my iPhone

On Jan 20, 2021, at 1:13 PM, Thomas G McConkey notifications@github.com wrote:

 So I think this can be managed just by some tweaking of the current logic flow.

User chooses to have the chip or a bounding box rendered If chip, the dimensions for the chip are used, regardless of circuit layout (if the user placed a transmon way outside the chip, well that is on them) If bounding box, the buffering values are used. The previous manner where we did full chip if all components rendered, bounding box if only some components are rendered, can be dropped and just replaced with the above. Although the previous allowed some simplicity and streamline, we found enough occourences that were problematic that I think the above suggested approach is probably the best case to go with.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

priti-ashvin-shah-ibm commented 3 years ago

Spoke with @dwang429 , need to have conversation with @zlatko-minev and @ThomasGM4

zlatko-minev commented 3 years ago

The user should be able to select to either render the full chip, or abounding box that is X or Y mm larger than the minimum Im bounding box enclosing all selected items.

I think Thomas had a nice explanation for this