search

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
288 stars 208 forks source link

fixed cancel button #666

Closed ghost closed 3 years ago

ghost commented 3 years ago

What are the issues this pull addresses (issue numbers / links)?

519

Did you add tests to cover your changes (yes/no)?

no

Did you update the documentation accordingly (yes/no)?

yes

Did you read the CONTRIBUTING document (yes/no)?

yes

Summary

Cancel button on closing window now works

Details and comments

ghost commented 3 years ago

Sorry, I should've made sure to test the other two. It turned out because of the @slot_catch_error() on ok_to_continue that ok_to_continue hadn't actually been returning anything at all when called. I removed @slot_catch_error() and checked that exceptions will still get printed in the Jupyter Notebook is they occur during that function.

ghost commented 3 years ago

@priti-ashvin-shah-ibm I think that's an unrelated issue to this PR. I just checked and I get your errors on the commit right before this PR (11afb730b7942945e0db3a94b8294d06beaa759c) and on main

JeremyDrysdale-ibm commented 3 years ago

@priti-ashvin-shah-ibm I think that's an unrelated issue to this PR. I just checked and I get your errors on the commit right before this PR (11afb73) and on main

If that's the case, please open that as a separate bug report.

I will re-review this Tuesday morning.