search

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
288 stars 208 forks source link

Incorrectly copied comments #668

Closed zachparrott closed 3 years ago

zachparrott commented 3 years ago

Information

What is the current behavior?

The comments for the run method in qiskit_metal.analyses.quantization.energy_participation_ratio.py are incorrectly copied from the run method of qiskit_metal.analyses.quantization.lumped_oscillator_model.py.

Steps to reproduce the problem

https://github.com/Qiskit/qiskit-metal/blob/e5cbb6559ed650cbb75e696322ccc7a918d9c5a9/qiskit_metal/analyses/quantization/energy_participation_ratio.py#L148-L157

https://github.com/Qiskit/qiskit-metal/blob/e5cbb6559ed650cbb75e696322ccc7a918d9c5a9/qiskit_metal/analyses/quantization/lumped_oscillator_model.py#L119-L130

What is the expected behavior?

Applicable description of the inputs and returns for EPR's run and not the LOM's run method.

Suggested solutions

Relevant comments.

zlatko-minev commented 3 years ago

Thanks, @zachparrott , for nothing this!