Closed marcolincs closed 2 years ago
1. is there a reason we want to give him the other?
A way to see the component options before making an instance of the component.
we find another way to force globals to non-routes. For example we could introduce a "QNonRoute" subclass from which all non route qlibrary inherit.....but this options seems to me excessively confounding.
Although clunky, might be the most straightforward
Changes made.
We forgot to discuss one last thing......should we call the option "orientation" or "rotation"? I vote for rotation since it is more industry standard in physical layout design EDA tools. Should we wait next Tue to finalize it? Meanwhile you can review?
Changes made.
We forgot to discuss one last thing......should we call the option "orientation" or "rotation"? I vote for rotation since it is more industry standard in physical layout design EDA tools. Should we wait next Tue to finalize it? Should we wait next Tue to finalize it? Meanwhile you can review?
rotation works for me
I am OK with either name of orientation or rotation.
What are the issues this pull addresses?
chip
default option was missing from the component. Currently there is several components missing that default option.This PR serves to eliminate the inconsistencies and the missing options.
NOTE: the global options are propagated to everything, including the transmission lines. However transmission lines do not have orientation or pos_y/x, since they anchor to other components. Therefore, inside the QRoute
__init__()
, I added a piece of code that deletes pos_x/y and orientation options. With this change, if the user calls:__init__()
, while this is a class method that does not execute the__init__()
.Therefore, either:
.options
to access things. is there a reason we want to give him the other?Did you add tests to cover your changes (yes/no)?
yes
Did you update the documentation accordingly (yes/no)?
yes
Did you read the CONTRIBUTING document (yes/no)?
yes