search

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
288 stars 208 forks source link

New LOM #709

Closed quantum-quant closed 2 years ago

quantum-quant commented 3 years ago

What are the issues this pull addresses (issue numbers / links)?

NA

Did you add tests to cover your changes (yes/no)?

no

Did you update the documentation accordingly (yes/no)?

yes

Did you read the CONTRIBUTING document (yes/no)?

yes

Summary

First version of new LOM model

Details and comments

zlatko-minev commented 3 years ago

fyi, the files changes in this only show 4 small files changed. This doesn't show the full code as changed

quantum-quant commented 3 years ago

fyi, the files changes in this only show 4 small files changed. This doesn't show the full code as changed

It's actually showing the full code. One of the 4 files is collapsed

zlatko-minev commented 3 years ago

Ah I see great somehow I missed it.

What about the demo notebooks?

Sent from my iPhone

On Sep 29, 2021, at 6:45 PM, Yehan Liu @.***> wrote:

 fyi, the files changes in this only show 4 small files changed. This doesn't show the full code as changed

It's actually showing the full code. One of the 4 files is collapsed

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

zlatko-minev commented 3 years ago

Nice

quantum-quant commented 3 years ago

Ah I see great somehow I missed it. What about the demo notebooks? … Sent from my iPhone On Sep 29, 2021, at 6:45 PM, Yehan Liu @.***> wrote:  fyi, the files changes in this only show 4 small files changed. This doesn't show the full code as changed It's actually showing the full code. One of the 4 files is collapsed — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

Added

zlatko-minev commented 2 years ago

How's it going with removing the need for some of these in the other branch

zlatko-minev commented 2 years ago

We ready to merge, @ThomasGM4 ?

zlatko-minev commented 2 years ago

@priti-ashvin-shah-ibm ?

priti-ashvin-shah-ibm commented 2 years ago

Didn't get a change to look yet. I will tomorrow afternoon after my appointment.