qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
288 stars 208 forks source link

open_to_ground_v2 #742

Closed fgnyilmaz closed 2 years ago

fgnyilmaz commented 2 years ago

open_to_ground default options were not generalized. width & gap and termination_gap was with some constant numbers so when One change their cpw_width and cpw_gap, open to ground's extra part was not changing accordingly.

What are the issues this pull addresses (issue numbers / links)? open_to_ground default options were not generalized. width & gap and termination_gap was with some constant numbers so when One change their cpw_width and cpw_gap, open to ground's extra part was not changing accordingly.

Did you add tests to cover your changes (yes/no)? Yes

Did you update the documentation accordingly (yes/no)? Yes

Did you read the CONTRIBUTING document (yes/no)? Yes

Summary When One want to use different cpw_with and cpw_gap, the extra part (that makes the resonator not grounded) of open to the ground does not change because it was fixed as 10um and 6um, respectively. I changed them to cpw_width and cpw_gap as needed and it works now. Analyses also work.