qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
279 stars 205 forks source link

Fixed Code Error in Issue #733(Additional PR) #748

Closed bopardikarsoham closed 2 years ago

bopardikarsoham commented 2 years ago

An addition to PR #746 @priti-ashvin-shah-ibm.

priti-ashvin-shah-ibm commented 2 years ago

@bopardikarsoham , For this notebook, did you execute it before generating this PR?

The issue had said, "The notebook in tut directory needs to be run ". The purpose of running/executing the cells is that when the notebook is posted in the documentation, other users can see what the expected output would be.

bopardikarsoham commented 2 years ago

I am getting an error: No module named "qiskit_metal" despite the fact I am running it in the cloned folder itself.

priti-ashvin-shah-ibm commented 2 years ago

I am getting an error: No module named "qiskit_metal" despite the fact I am running it in the cloned folder itself.

To run the notebooks, one has to make a conda env based on the directions in link below. I had assumed you already had one set up.

https://qiskit.org/documentation/metal/installation.html

zlatko-minev commented 2 years ago

Thanks for the pull. It looks like the code just fixes a simple typo of size_y to size_x. Shouldn't affect anything else

bopardikarsoham commented 2 years ago

@bopardikarsoham , For this notebook, did you execute it before generating this PR?

The issue had said, "The notebook in tut directory needs to be run ". The purpose of running/executing the cells is that when the notebook is posted in the documentation, other users can see what the expected output would be.

@priti-ashvin-shah-ibm Do you want me to show it as a tutorial? I can do that too.

priti-ashvin-shah-ibm commented 2 years ago

@bopardikarsoham , For this notebook, did you execute it before generating this PR? The issue had said, "The notebook in tut directory needs to be run ". The purpose of running/executing the cells is that when the notebook is posted in the documentation, other users can see what the expected output would be.

@priti-ashvin-shah-ibm Do you want me to show it as a tutorial? I can do that too.

@bopardikarsoham , yes , thank you! The updated notebook would need to be executed with the updated output and the shared in the docs.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

bopardikarsoham commented 2 years ago

Here is the PR #759 @priti-ashvin-shah-ibm.

priti-ashvin-shah-ibm commented 2 years ago

Per request of contributor on Pull request #759, I am closing this pull request.