qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
279 stars 205 forks source link

Final PR for Issue #733 #759

Closed bopardikarsoham closed 2 years ago

bopardikarsoham commented 2 years ago

@priti-ashvin-shah-ibm. I have fixed the typos in both files and have also run both the notebooks to show it as a tutorial. This is my final PR and you can close PR #746 and #748.

priti-ashvin-shah-ibm commented 2 years ago

@bopardikarsoham , we have has some issues with the CLA bot. Even though contributor has signed it, we need to ask them to sign again. Can you please sign the CLA again.

bopardikarsoham commented 2 years ago

Ok, I have signed the CLA again

priti-ashvin-shah-ibm commented 2 years ago

Per your request, I will close PR #746 and #748.

bopardikarsoham commented 2 years ago

Is the PR ok? @priti-ashvin-shah-ibm

priti-ashvin-shah-ibm commented 2 years ago

@bopardikarsoham , I see that we could merge this, however, there are many warnings in the notebooks which would show in documentation. Let's wait till the fix for issue #727. After that fix is merged, the repository will be updated so the warnings will not occur in the notebooks you ran.

https://github.com/Qiskit/qiskit-metal/issues/727

bopardikarsoham commented 2 years ago

Ok, no problem @priti-ashvin-shah-ibm

priti-ashvin-shah-ibm commented 2 years ago

HI @bopardikarsoham

The fix to address the warnings for shapely depreciation just merged to main. We were waiting for this merge before running the books.

So, now, if you can make a new conda environment from latest commit on main, then run the notebooks, the output of the cells in the notebook shouldn't have the warnings in them.

bopardikarsoham commented 2 years ago

Sure @priti-ashvin-shah-ibm

priti-ashvin-shah-ibm commented 2 years ago

@bopardikarsoham , since you opened a different pull request, I am closing this pull request.