qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
279 stars 205 forks source link

Use non default Chip name and layer number #771

Closed priti-ashvin-shah-ibm closed 1 year ago

priti-ashvin-shah-ibm commented 2 years ago

Information

What is the current behavior?

@Ray Parker was using non default chip name and could not create a gds file as desired.

add_qgeometry needs to have to updated chip name and layer number. If the chip and layer number have not been added, then use the latest values from options, not the default.

Steps to reproduce the problem

Conversation in Slack #metal.

What is the expected behavior?

Suggested solutions

priti-ashvin-shah-ibm commented 2 years ago

As an afterthought, I think there should also be a check for the chip name existing with design.chips. If the chip information is not there for that chip name, need to give an error.

priti-ashvin-shah-ibm commented 2 years ago

I added an error for the pull request.

priti-ashvin-shah-ibm commented 1 year ago

code in pull request.