qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
279 stars 205 forks source link

Implement Ability to Extract Q-factors from Eigenmode Simulations #789

Closed SamarthH closed 2 years ago

SamarthH commented 2 years ago

What are the issues this pull addresses (issue numbers / links)?

Did you add tests to cover your changes (yes/no)?

yes

Did you update the documentation accordingly (yes/no)?

no

Did you read the CONTRIBUTING document (yes/no)?

yes

Summary

This pull request implements the ability to render and use resistive ports in Eigenmode simulations in order to find the Q-factors of resonators and to simulate other dissipative effects.

Details and comments

SamarthH commented 2 years ago

For some reason, git is not diffing the files properly, and hence the commit looks much much larger than it is. It is just a few lines of code in execute_design and create_ports.

gsteele13 commented 2 years ago

i would love to try this out!

SamarthH commented 2 years ago

Sorry for the delay. I shall also push the extra meshing part in a moment.

SamarthH commented 2 years ago

I think that this is all that I have to implement at the moment. Please review this and let me know of any necessary changes @zlatko-minev @ThomasGM4 . Thanks a lot!

ThomasGM4 commented 2 years ago

Thanks for working on this. Will look through the code shortly, might take a little bit extra just because of the way the diff is for the entire file instead of the code you changed (I am also not sure why it did it like that).

zlatko-minev commented 2 years ago

Ditto @ThomasGM4 , excited to look over, thanks for the contribution work!

SamarthH commented 2 years ago

@ThomasGM4 : I have cleared the outputs of the tutorial notebook and made the requisite changes. Please take a look. Thanks

SamarthH commented 2 years ago

@ThomasGM4 : Could you please merge the commits into the main branch? Then I would close the pull request.