Closed SamarthH closed 2 years ago
For some reason, git is not diffing the files properly, and hence the commit looks much much larger than it is. It is just a few lines of code in execute_design and create_ports.
i would love to try this out!
Sorry for the delay. I shall also push the extra meshing part in a moment.
I think that this is all that I have to implement at the moment. Please review this and let me know of any necessary changes @zlatko-minev @ThomasGM4 . Thanks a lot!
Thanks for working on this. Will look through the code shortly, might take a little bit extra just because of the way the diff is for the entire file instead of the code you changed (I am also not sure why it did it like that).
Ditto @ThomasGM4 , excited to look over, thanks for the contribution work!
@ThomasGM4 : I have cleared the outputs of the tutorial notebook and made the requisite changes. Please take a look. Thanks
@ThomasGM4 : Could you please merge the commits into the main branch? Then I would close the pull request.
What are the issues this pull addresses (issue numbers / links)?
Did you add tests to cover your changes (yes/no)?
yes
Did you update the documentation accordingly (yes/no)?
no
Did you read the CONTRIBUTING document (yes/no)?
yes
Summary
This pull request implements the ability to render and use resistive ports in Eigenmode simulations in order to find the Q-factors of resonators and to simulate other dissipative effects.
Details and comments