Double-side loaded transmission line model and multi-node subsystems - Githubissues

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.

https://qiskit-community.github.io/qiskit-metal/

Apache License 2.0

279 stars 205 forks source link

Double-side loaded transmission line model and multi-node subsystems #791

Closed quantum-quant closed 2 years ago

quantum-quant commented 2 years ago

What are the issues this pull addresses (issue numbers / links)?

Implemented double-side loaded TL resonator model
New TL model nicely resolves to single-side loaded and/or single-side shorted models under approriate boundary conditions
Generalize multi-node subsystems which were necessary for the double-sided TL model

Did you add tests to cover your changes (yes/no)?

Checked and verified that the double-side loaded TL model can recover single-side loaded results under approriate bouonary conditions
Check that new changes do not break existing tutorials/applications

Did you update the documentation accordingly (yes/no)?

yes

Did you read the CONTRIBUTING document (yes/no)?

yes

Summary

Details and comments

ThomasGM4 commented 2 years ago

I presume want to merge in #790 first?