don't include ground node in system nodes

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.

https://qiskit-community.github.io/qiskit-metal/

Apache License 2.0

279 stars 205 forks source link

don't include ground node in system nodes #792

Closed quantum-quant closed 2 years ago

quantum-quant commented 2 years ago

What are the issues this pull addresses (issue numbers / links)?

Currently for grounded transmons, the ground node is included in the construction of system nodes (which is only used to check that no systems have overlapping nodes). This PR fixes this bug.

Did you add tests to cover your changes (yes/no)?

Did you update the documentation accordingly (yes/no)?

Did you read the CONTRIBUTING document (yes/no)?

Summary

Details and comments

quantum-quant commented 2 years ago

In the process of fixing this bug (which was discovered in the web app development), I found another bug which was related to a previous bug fix PR.