Closed SamarthH closed 2 years ago
@ThomasGM4 : Can you please review this? Thanks
@ThomasGM4 In case all the issues have been addressed, could you please merge and close this pull request? Thanks
Hey @SamarthH , stumbled across another error while doing some tests of this PR. Pretty sure it is unrelated but wanting to make certain first.
May I ask what the error is? Thanks
What are the issues this pull addresses (issue numbers / links)?
Fixed issues with the earlier pull request. Now works with Q3D.
Did you add tests to cover your changes (yes/no)?
yes
Did you update the documentation accordingly (yes/no)?
yes
Did you read the CONTRIBUTING document (yes/no)?
yes
Summary
This pull request implements the ability to render and use resistive ports in Eigenmode simulations in order to find the Q-factors of resonators and to simulate other dissipative effects.
Details and comments