qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
279 stars 205 forks source link

Implement Ability to Extract Q-factors from Eigenmode Simulations #794

Closed SamarthH closed 2 years ago

SamarthH commented 2 years ago

What are the issues this pull addresses (issue numbers / links)?

Fixed issues with the earlier pull request. Now works with Q3D.

Did you add tests to cover your changes (yes/no)?

yes

Did you update the documentation accordingly (yes/no)?

yes

Did you read the CONTRIBUTING document (yes/no)?

yes

Summary

This pull request implements the ability to render and use resistive ports in Eigenmode simulations in order to find the Q-factors of resonators and to simulate other dissipative effects.

Details and comments

SamarthH commented 2 years ago

@ThomasGM4 : Can you please review this? Thanks

SamarthH commented 2 years ago

@ThomasGM4 In case all the issues have been addressed, could you please merge and close this pull request? Thanks

ThomasGM4 commented 2 years ago

Hey @SamarthH , stumbled across another error while doing some tests of this PR. Pretty sure it is unrelated but wanting to make certain first.

SamarthH commented 2 years ago

May I ask what the error is? Thanks