qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
276 stars 205 forks source link

795 conda env python3 10 #807

Closed priti-ashvin-shah-ibm closed 2 years ago

priti-ashvin-shah-ibm commented 2 years ago

What are the issues this pull addresses (issue numbers / links)?

795 is mostly finished, however, we still need to add python 3.10 CI.

Did you add tests to cover your changes (yes/no)?

no

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

yes

Summary

pyaedt has dependencies which limit python to 3.9. So we are holding off on merging this pull request for now.

Details and comments

priti-ashvin-shah-ibm commented 2 years ago

This work was done by @GyeonghunKim as part of QAMP.

priti-ashvin-shah-ibm commented 2 years ago

Regarding Qiskit Metal, when we are using the latest commit, the conda environment has python 3.10. When we add the dependencies for pyaedt i.e. PythonNet and PyVista, then generate a new conda env, the environment is python 3.9. This makes us believe PythonNet and PyVista have some code which is not python 3.10 compatible. This is just sharing of information; however, it would be ideal to not limit python version.

priti-ashvin-shah-ibm commented 2 years ago

We noticed pyaedt is not part of conda-forge. If we want to use that package, we would need to manually pip install.

priti-ashvin-shah-ibm commented 2 years ago

@GyeonghunKim Thank you for all of your help to get the repo to work with python 3.10.