search

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
276 stars 205 forks source link

Added 3D vector class #811

Closed AbeerVaishnav13 closed 2 years ago

AbeerVaishnav13 commented 2 years ago

What are the issues this pull addresses (issue numbers / links)?

808

Did you add tests to cover your changes (yes/no)?

Yes. Modified qiskit_metal/tests/test_draw.py to include tests for new code.

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

Added a 3D vector class Vec3D for extending functionality to be used by future renderers (like Gmsh).

Details and comments

Gmsh renderer uses 3D vectors natively to avoid the conversion and confusion between 2D and 3D vectors. this class adds the feature to use 3D vectors and extends the functionality.