qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
276 stars 205 forks source link

Move fillet functions from gmsh_utils.py to toolbox #817

Closed AbeerVaishnav13 closed 2 years ago

AbeerVaishnav13 commented 2 years ago

Please be as descriptive as possible, including: what is expected, why is this feature needed, what is the objective, etc.

What is the feature being requested?

Move the custom fillet functions written for Gmsh, to a separate toolbox so that GDS renderer can use it too!

What are use cases for this feature?

Use the fillet functions written for Gmsh, to render fillets in GDS. Additional features included in the new fillet functions:

  1. Arbitrary angle fillets
  2. Ability to perform the fillet and transform in any arbitrary location.
AbeerVaishnav13 commented 2 years ago

GDS renderer already has an in-built fillet functionality and there's no need of shifting this code to a toolbox. This change is not planned. Closing this issue.