Fix for `thickness=0` and 3D junctions issue with Gmsh renderer - Githubissues

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.

https://qiskit-community.github.io/qiskit-metal/

Apache License 2.0

283 stars 209 forks source link

Fix for `thickness=0` and 3D junctions issue with Gmsh renderer #854

Closed AbeerVaishnav13 closed 2 years ago

AbeerVaishnav13 commented 2 years ago

What are the issues this pull addresses (issue numbers / links)?

Closes #846 Closes #842

Did you add tests to cover your changes (yes/no)?

No

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

This PR is a work in progress and solves the issue which occurs when giving thickness=0 for a layer in MultiPlanar with Gmsh renderer.

Details and comments

Functions to be changed (potentially):

[x] render_layers()
[x] subtract_from_layers()
[x] fragment_interfaces()
[x] assign_physical_groups()
[x] define_mesh_size_fields()
[x] assign_mesh_color()