search

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
283 stars 209 forks source link

Gmsh renderer doesn't assign physical group to dielectric volume when `ignore_metal_volume=True` #861

Closed AbeerVaishnav13 closed 1 year ago

AbeerVaishnav13 commented 1 year ago

Information

What is the current behavior?

Gmsh renderer fails to assign physical group to dielectric volumes due to a bug in one of the if statements within the assign_physical_groups method in the code.

Steps to reproduce the problem

Render any QGeometry using the QGmshRenderer and open Tools > Visibility, change to Physical Groups in the drop down menu. We'll not see any volume corresponding to dielectric layers due to this bug.

What is the expected behavior?

It should assign the physical groups to dielectric volumes.

Suggested solutions

Fix upcoming in a new PR.