search

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
272 stars 201 forks source link

Fix for Gmsh renderer not assigning physical group to dielectric volumes #862

Closed AbeerVaishnav13 closed 1 year ago

AbeerVaishnav13 commented 1 year ago

What are the issues this pull addresses (issue numbers / links)?

Closes #861

Did you add tests to cover your changes (yes/no)?

Yes

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

Fixes the bug mentioned in #861

Details and comments

Changed the behavior of if statements in the method assign_physical_groups to include extra cases where it was failing.