qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
283 stars 209 forks source link

Fix for QGmshRenderer adding a ground_plane physical group even when … #873

Closed AbeerVaishnav13 closed 1 year ago

AbeerVaishnav13 commented 1 year ago

…it is not in the model.

What are the issues this pull addresses (issue numbers / links)?

Closes #872 Issue found by @diemilio and requires a minor change to fix it by adding a check for the ground plane layer if the layers_dict is empty or not.

Did you add tests to cover your changes (yes/no)?

No

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

This solves the issue that was caused due to missing a condition to check if the layers having ground plane actually exist in the model or not.

Details and comments

Branch can be deleted after merging.