Pre-Commit Hook - Githubissues

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.

https://qiskit-community.github.io/qiskit-metal/

Apache License 2.0

272 stars 201 forks source link

Pre-Commit Hook #874

Closed cdelnano closed 1 year ago

cdelnano commented 1 year ago

Information

Qiskit Metal version: Latest as of 11/8
Python version: 3.1
Operating system: Mac

What is the current behavior?

The pre-commit hook looks at BOTH .py and .ipynb files.

Steps to reproduce the problem

I tried to delete a .ipynb file that was no longer needed, and the yapf formatting raised an error when I tried to commit this change.

What is the expected behavior?

The pre-commit hook should only look at .py files, not .ipynb files.

Suggested solutions

Modify the pre-commit hook so that it only looks at .py files, not .ipynb files.

priti-ashvin-shah-ibm commented 1 year ago

Merged, should be closed.