priti-ashvin-shah-ibm
commented
1 year ago Some thoughts:
- the method to save your work is
design.to_python_script. I believe this is what the GUI also uses. - https://github.com/Qiskit/qiskit-metal/blob/main/tutorials/1%20Overview/1.3%20Saving%20Your%20Chip%20Design.ipynb
- That code about pickle is probably depreciated.
- I don’t see a test in CI using to_python_script, so I believe that we can not write to disk when going through CI.
- It seems that save_design was not working and you may have fixed it. Are you able to read what you wrote to file and use save_design? My memory says there was a reason we didn’t continue with pickleing. Not sure why?????
- Lastly, can you look into to_python_script and see if that works for you? If you notice, in the tutorials, there is no demo of save_design.
jagandecapri
What are the issues this pull addresses (issue numbers / links)?
Fixes #910.
This is my suggested solution. Please kindly advise if there are other side effects that I have not considered or aware of. 🙂
Did you add tests to cover your changes (yes/no)?
Yes.
On another note, other test cases are passing in my local at least. However, I would appreciate if there is feedback on the possible other side-effects from the changes I am proposing.
Did you update the documentation accordingly (yes/no)?
No.
Did you read the CONTRIBUTING document (yes/no)?
Yes.
Summary
Currently, when saving a QDesign using the save_design method, throws an error saying
ERROR WHILE SAVING: 'NoneType' object is not callable.When the save_design error is fixed using suggestion solution (1), then another error appear when load_design. The error is
RecursionError: maximum recursion depth exceeded.The proposed changes in this PR is to fix the issues mentioned above.
Details and comments