search

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
270 stars 201 forks source link

Expose result of convergence of LOM analysis' Q3D renderer to end user #915

Closed jagandecapri closed 1 year ago

jagandecapri commented 1 year ago

✅ I have added the tests to cover my changes. ✅ I have updated the documentation accordingly. ✅ I have read the CONTRIBUTING document.

What are the issues this pull addresses (issue numbers / links)?

Fixes #914

Did you add tests to cover your changes (yes/no)?

Yes

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

Currently, the result of convergence of LOM Analysis' Q3D renderer is not exposed to the end user. Exposing the result of convergence to the user would give feedback to the user on whether the results obtained is reliable. Users can also programatically increase the number of passes and rerun the simulation to achieve convergence.

Details and comments

The PR only covers Q3D renderer at the moment.

priti-ashvin-shah-ibm commented 1 year ago

Will merge for you.