qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
283 stars 209 forks source link

Fix for layout of the GDS/Q3D export window in the gui #938

Closed Shark-y closed 1 year ago

Shark-y commented 1 year ago

Issue #549 https://github.com/Qiskit/qiskit-metal/issues/549

The scaling for the GDS/Q3D/HFSS dialogs should be fixed now.

What are the issues this pull addresses (issue numbers / links)?

Issue 549: Small bug in layout of the GDS/Q3D export window in the gui https://github.com/Qiskit/qiskit-metal/issues/549

Did you add tests to cover your changes (yes/no)?

No. These are UI layout changes that must be tested manually by scaling the GDS/Q3D & HFSS render dialogs. There are no python updates. Just QT UI XML

Did you update the documentation accordingly (yes/no)?

No. I did not find documentation for QT UI XML updates.

Did you read the CONTRIBUTING document (yes/no)?

yes

Summary

Updates the QT XML UI for the GDS/Q3D & HFSS render dialogs.

Details and comments

This is my first attempt at fixing bugs in Qiskit Metal. Please review & let me know if you like them. I made simple updates to the QT XML to auto scale the GDS/Q3D & HFSS render dialogs.

Thank you for your wonderful software.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Shark-y commented 1 year ago

Wrapped the widgets in a GridLayout using the QT designer, so they auto scale at any resolution. The dialog size is left the same. Here are some screen shots at multiple sizes

image image

HFSS

image

Q3D

image

Also related to https://github.com/Qiskit/qiskit-metal/issues/527

Shark-y commented 1 year ago

Good Morning, A fix for https://github.com/Qiskit/qiskit-metal/issues/45

I should have created a new branch from my last pull request :(

Anyway, the QComponents table now has a QSortFilterProxyModel as shown in the screen shots, you can now sort the table and filter using the text box.

image image

Moved this to a new PR. Sorry for the mistake.

priti-ashvin-shah-ibm commented 1 year ago

To get linting to pass, save your python files with yapf formatting.

Shark-y commented 1 year ago

Good morning. Is there a way to run the above tests from the dev env? Thanks.

priti-ashvin-shah-ibm commented 1 year ago

https://github.com/Qiskit/qiskit-metal/blob/main/.pylintrc

Look at line 17 and 18

If these are autogenerated, the files need to be added here.

Shark-y commented 1 year ago

Tested in Windows 10.