search

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
283 stars 209 forks source link

Issue 45 q components sort filter #939

Closed Shark-y closed 1 year ago

Shark-y commented 1 year ago

What are the issues this pull addresses (issue numbers / links)?

https://github.com/Qiskit/qiskit-metal/issues/45

Did you add tests to cover your changes (yes/no)?

No. This is a UI bug fix.

Did you update the documentation accordingly (yes/no)?

No. This is a UI bug fix.

Did you read the CONTRIBUTING document (yes/no)?

yes

Summary

The QComponents table now has a QSortFilterProxyModel (see screen shots), you can now sort the table and filter using the text box.

Details and comments

Good Morning, A fix for https://github.com/Qiskit/qiskit-metal/issues/45

The QComponents table now has a QSortFilterProxyModel as shown in the screen shots, you can now sort the table and filter using the text box.

image image

Shark-y commented 1 year ago

Moved this commit from my last PR https://github.com/Qiskit/qiskit-metal/pull/938 to a new one. Sorry for the mistake.

priti-ashvin-shah-ibm commented 1 year ago

To get linting to pass, save your python files with yapf formatting.

Shark-y commented 1 year ago

Good Morning, Is there a way to rune the above tests from the local dev env? Thanks.

priti-ashvin-shah-ibm commented 1 year ago

You can make a draft pull request, which will run the github actions for tests.

priti-ashvin-shah-ibm commented 1 year ago

https://github.com/Qiskit/qiskit-metal/blob/main/.pylintrc

Look at line 17 and 18

If these are autogenerated, the files need to be added here.

Shark-y commented 1 year ago

Hi. Tested in Windows 10.