search

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
270 stars 201 forks source link

Added multi-freq & broadband support. Added interpolation settings to freq sweep. All under `QHFSSDrivenmodalPyaedt` #944

Closed clarkmiyamoto closed 1 year ago

clarkmiyamoto commented 1 year ago

What are the issues this pull addresses (issue numbers / links)?

https://github.com/Qiskit/qiskit-metal/issues/943

Did you add tests to cover your changes (yes/no)?

No - unsure how to add test for hfss freq sweep & setup.

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

All changes in QHFSSDrivenmodalPyaedt

Details and comments

clarkmiyamoto commented 1 year ago

@zlatko-minev hey! just caught a bug in the add_hfss_dm_setup thanks for making me double check haha. Everything is good now

zlatko-minev commented 1 year ago

Great job!

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

clarkmiyamoto commented 1 year ago

hey @zlatko-minev hope you're doing well. Was wondering if there's anything preventing these changes from being merged? Lmk and thanks!

zlatko-minev commented 1 year ago

Thank you, @clarkmiyamoto ! Planning to merge