qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
270 stars 201 forks source link

Dependencies pinned too tightly #945

Open wshanks opened 1 year ago

wshanks commented 1 year ago

921 pinned all of the versions in requirements.txt to specific versions in order to avoid test failures. It makes sense to pin the dependency versions in tests to ensure consistency, but requirements.txt also gets used to pass to install_requires of setuptools to set the dependency versions of the package. Having all the dependencies pinned to specific versions (rather than looser ranges) makes it difficult to use qiskit-metal in an environment with other packages because all of those other packages have to be compatible with all of the pinned versions of qiskit-metal's dependencies.

If you want the tests to run against fixed dependency versions, one option is to add another requirements file named something like requirements-frozen.txt or requirements-pinned.txt, with all of the dependencies pinned while leaving looser ranges in requirements.txt. Then in tox.ini, you can put -r requirements-pinned.txt under the deps entry. Something to keep in with this approach is that if you allow newer versions of dependencies in requirements.txt but are not testing against them in CI you will not discover issues with new versions of the dependencies until a user complains.

zlatko-minev commented 1 year ago

Thank you, Will. We should do this.

I'm looking for help from folks here to try this?

AbdullahKazi500 commented 1 year ago

Hi @zlatko-minev I am completely new to Metal and to open source may I try this issue I have a background in experimental physics and solid modelling of integrated circuits on ansys