search

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
270 stars 201 forks source link

Added ability to change length of pin/CPW leading out of transmon cross #949

Closed andrekuo closed 1 year ago

andrekuo commented 1 year ago

What are the issues this pull addresses (issue numbers / links)?

946 , #948

Did you add tests to cover your changes (yes/no)?

946: No, not sure if any new tests are needed 948: No, docs change

Did you update the documentation accordingly (yes/no)?

946: Yes 948: No, not applicable

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

Added ability to input custom dimensions for the pin attached to the Transmon Cross Also, fixed issue #948

Details and comments

zlatko-minev commented 1 year ago

There seem to be some check failing, could you take a look and see if you may be able to resolve them? See image here for instance from the linter:

image
CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

andrekuo commented 1 year ago

@zlatko-minev just realized I forgot to update the unit test, should be fixed now!

zlatko-minev commented 1 year ago

Great work, I assume you tested and it's backwards compatible. Will merge after checks