qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
270 stars 201 forks source link

Add `pyEPR` to `QHFSSEigenmodePyaedt` #951

Closed clarkmiyamoto closed 1 year ago

clarkmiyamoto commented 1 year ago

What are the issues this pull addresses (issue numbers / links)?

https://github.com/Qiskit/qiskit-metal/issues/950

Did you add tests to cover your changes (yes/no)?

No - unsure how to add tests to ANSYS level code... Please advise.

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

Added energy-participation ratio analysis using QHFSSEigenmodePyaedt renderer by using pyEPR. Nice temporary fix until someone implements pyEPR only using pyAEDT.

Details and comments

Changes in QHFSSPyaedt‎

Changes in QHFSSEigenmodePyaedt

Added tutorial on how to QHFSSEigenmodePyaedt.

clarkmiyamoto commented 1 year ago

Also side note. I noticed other pieces of code aren't yapf formatted, should I be running this or have it routed to only my code? I wouldn't want to break anything.

yapf --in-place --recursive --style ./.style.yapf .

I currently modify it to run only the sections I've changed. yapf --in-place --recursive --style ./.style.yapf ./qiskit_metal/renderers/renderer_ansys_pyaedt