qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
270 stars 201 forks source link

Fixed charge dispersion equation typo in LOM analysis #953

Closed eliaslehman closed 1 year ago

eliaslehman commented 1 year ago

What are the issues this pull addresses (issue numbers / links)?

Fixes #851

The dispersion equation in qiskit_metal\analyses\quantization\lumped_capacitive.py miscalculated charge dispersion $\epsilon$ by not including a 2 under the square root. Now the calculation matches analytical calculations according to Charge-insensitive qubit design derived from the Cooper pair box, PhysRevA.76.042319.

Before:

Screen Shot 2023-06-13 at 1 54 34 PM

After:

Screen Shot 2023-06-13 at 1 54 15 PM

Did you add tests to cover your changes (yes/no)?

I did not add any tests as test_analyses_2_functionality.py covers this change. My changes pass run_all_tests.py, test_analyses_2_functionality.py and test_analyses_1_inst_options.py.

Did you update the documentation accordingly (yes/no)?

I did not update the documentation as the documentation does not pertain to this change. The functionality of the transmon_props() method remains the same.

Did you read the CONTRIBUTING document (yes/no)?

Yes I did.

Summary

This brief commit fixes the charge dispersion calculation in the transmon_props() function within the file qiskit_metal\analyses\quantization\lumped_capacitive.py. This calculation is important as it contributes to the calculation of a device T1 time, an important metric of quantum devices.

Details and comments

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

eliaslehman commented 1 year ago

@zlatko-minev I signed the form yesterday, I guess the comments stick around. Let me know if there is an issue and I'll try to resolve it.

zlatko-minev commented 1 year ago

Thank you!