search

qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
270 stars 201 forks source link

Added more options for custom claws in TransmonCross #957

Open clarkmiyamoto opened 1 year ago

clarkmiyamoto commented 1 year ago

What are the issues this pull addresses (issue numbers / links)?

Slight corrections & improvements to https://github.com/qiskit-community/qiskit-metal/pull/949

Did you add tests to cover your changes (yes/no)?

Yes, updated corresponding tests for TransmonCross.

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

yes

Summary

The standard MIT LL candle qubit has a nonuniform claw thickness. One of the assumptions in the current TransmonCross is that you have uniform claw thickness, so this design isn't possible in Qiskit Metal (before this PR!). This update is to give front-end users more control of their claw designs.

Screen Shot 2023-06-21 at 11 17 54 PM

To illustrate what I mean here's a new potential design you can create.

And yes, it is backward compatible!

Details and comments

zlatko-minev commented 1 year ago

Ready for a review?

clarkmiyamoto commented 1 year ago

Ready for a review?

Yeah ready!

clarkmiyamoto commented 1 year ago

in

Correct. If the user doesn't input ground_spacing_back or claw_width_back it'll default to a uniform style.

zlatko-minev commented 12 months ago

It's overall looking good to me, I'll plan to merge