qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
270 stars 201 forks source link

New feautures to QMetal - Adding logo, Creating Qcomponents from Images #959

Open SimonTheRocketGuy opened 1 year ago

SimonTheRocketGuy commented 1 year ago

What are the issues this pull addresses (issue numbers / links)?

Did you add tests to cover your changes (yes/no)?

Did you update the documentation accordingly (yes/no)?

Did you read the CONTRIBUTING document (yes/no)?

Summary

Adding logo, Creating Qcomponents from Images

Details and comments

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

zlatko-minev commented 1 year ago

Hi Simon, congratulations on your first pull request on the new repo, thank you very much for making it. Have you signed the CLA above?

zlatko-minev commented 1 year ago

Let me know if you see these messages

SimonTheRocketGuy commented 1 year ago

I see the messages

zlatko-minev commented 12 months ago

Thanks, @SimonTheRocketGuy !

Some questions:

  1. Do we need another license file? tutorials/5 Logo_from_img/Qiskit_Metal-Add_Logo/LICENSE There is already an APACHE license at the top of the repo. We don't usually add per module licenses
zlatko-minev commented 12 months ago

Could we also move the tutorial folders to organize and keep concisent with the rest of the repo.

Perhaps placing them under a folder

Then we can add them to the docs from there in the auto gallery

SimonTheRocketGuy commented 12 months ago

OH... yesss! License is there by a mistake. I added it to every repo in my git account auto and then it just copied here... Of course! That would be great! I did not know where to place it at first... Thanks!

zlatko-minev commented 12 months ago

Thanks, feel free to update the PR here so i can check and merge