qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
270 stars 201 forks source link

Added airbridges to `QGDSRenderer` #962

Open clarkmiyamoto opened 1 year ago

clarkmiyamoto commented 1 year ago

What are the issues this pull addresses (issue numbers / links)?

Partially https://github.com/qiskit-community/qiskit-metal/issues/906

Did you add tests to cover your changes (yes/no)?

Yes

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

Users can now add airbridges when exporting to GDS.

Screen Shot 2023-06-26 at 10 25 06 PM

And yes, this can support MIT LL airbridges but will require the user to design their own airbridge via QComponents. I'd upload the correct QComponent, but unfortunately, we're not allowed to share design guidelines.

Details and comments

In QGDSRenderer.export_to_gds, it now calls self._populate_airbridge. This mimics the structure of cheesing. Meaning we have a file make_airbridge.py which contains all the airbridge position extraction logic.

Limitations:

Things for the next person to add (I'll add issues for these)

clarkmiyamoto commented 1 year ago

If docs check finishes properly, then ready for review!

Also apologies for the excess commits, my work computer is out of reach so I'm coding w/o an environment and then I pull changes via the work computer w/ qiskit metal environment to test.

clarkmiyamoto commented 1 year ago

@priti-ashvin-shah-ibm @ThomasGM4 Finally got around to working on this, it was a busy last semester 😅. Thank you both for helping point me in the right direction for this.

clarkmiyamoto commented 9 months ago

@zlatko-minev Hi just wanted to give you an update, no longer working on scq stuff atm. Just wanted to know if you were gonna PR this. If not I'll close to reduce clutter.

zlatko-minev commented 9 months ago

Thank you, @clarkmiyamoto . Wondering what you are now up to. Let me fix a few things and look it over, I'd like to merge it, any chance you can make sure it looks ok with the latest other pulls?

clarkmiyamoto commented 9 months ago

Just started grad school at NYU, gonna try out a few different fields (high energy, applied mathematics, complexity science, etc.) during my first year. And then I might return to QIS!

As for the code, it works inside the GDS Renderer and mirrors the structure for the cheesing code, so I think it's pretty well contained. Let me know if you see any potential issues and I can still help out as needed.