qiskit-community / qiskit-metal

Quantum Hardware Design. Open-source project for engineers and scientists to design superconducting quantum devices with ease.
https://qiskit-community.github.io/qiskit-metal/
Apache License 2.0
270 stars 201 forks source link

Adding datatype to the Qgeometry #983

Open maxhant opened 5 months ago

maxhant commented 5 months ago

What are the issues this pull addresses (issue numbers / links)?

It is based on Issue #982.

Did you add tests to cover your changes (yes/no)?

No.

Did you update the documentation accordingly (yes/no)?

No, only doctstrings.

Did you read the CONTRIBUTING document (yes/no)?

Yes, but I am not an experienced programmer.

Summary

I am adding the sublayer parameter to the qgeometry default parameters. It corresponds to the datatype kwarg that is being passed to the gdspy. This will allow experimentalists to have different sublayers in the GDS file. This is useful if one wants to expose areas with greater doses in lithography. This works better than creating a new layer because the cheesing is ignoring higher layers, thus it would overlap with the added feature because they correspond physically to the same layer.

Details and comments

It is not working for now, and I am getting some help in the issue #982 from @zlatko-minev. It is only giving my datatypes of value 0 since I have made those changes.