qiskit-community / qiskit-nature-pyscf

Documentation at https://qiskit-community.github.io/qiskit-nature-pyscf/
Apache License 2.0
18 stars 10 forks source link

Changed to install qiskit not qiskit-terra #58

Closed woodsp-ibm closed 6 months ago

woodsp-ibm commented 7 months ago

Summary

It seems the CI actions and workflows had not been updated and still referred to and installed qiskit-terra. That is no longer part of Qiskit 1.0 and so it installed a pre-1.0 version where qiskit-terra was still there. Later it ended up installing Qiskit 1.0 and with both in the same environment things failed.

I changed the actions to no longer refer to anything as Terra and install Qiskit only.

Details and comments

Probably want to backport this to keep the stable branch running too.

woodsp-ibm commented 7 months ago

This is now working better - but failing since stable released Nature is not compatible with Qiskit 1.0 in terms of using the qiskit.tools parallel_map function which was moved etc

woodsp-ibm commented 6 months ago

I updated things as they were and changed qiskit-terra to qiskit. As the requirements do not call out qiskit explictly that could be possible what you say, but it still has all that stuff in there that allows it to be run off of main branches for either, not only stable. Could one simplify the CI here further - I imagine, I just updated what was there.

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 7937030412

Details


Totals Coverage Status
Change from base Build 7893470074: 0.0%
Covered Lines: 141
Relevant Lines: 175

💛 - Coveralls