search

qiskit-community / qiskit-nature

Qiskit Nature is an open-source, quantum computing, framework for solving quantum mechanical natural science problems.
https://qiskit-community.github.io/qiskit-nature/
Apache License 2.0
291 stars 197 forks source link

Ci is failing in mypy checks #1309

Closed woodsp-ibm closed 5 months ago

woodsp-ibm commented 5 months ago

Nighlty CI is failing as follows

Error: qiskit_nature/second_q/hamiltonians/lattices/lattice.py:25: error: Unused "type: ignore" comment  [unused-ignore]
Error: qiskit_nature/second_q/hamiltonians/lattices/hexagonal_lattice.py:17: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_triangular_lattice.py:17: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_square_lattice.py:17: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_line_lattice.py:17: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_lattice.py:20: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_kagome_lattice.py:18: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_hyper_cubic_lattice.py:17: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/lattices/test_hexagonal_lattice.py:17: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/test_ising_model.py:19: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/test_heisenberg_model.py:16: error: Unused "type: ignore" comment  [unused-ignore]
Error: test/second_q/hamiltonians/test_fermi_hubbard_model.py:18: error: Unused "type: ignore" comment  [unused-ignore]

which seems attributable to yesterdays (23 Jan) release of a new rustworkx version. The prior run that passed was on 0.13.2 and the new version is 0.14.0

This is a new feature release of Rustworkx that adds many new features to the library. The highlights of this release are:

   * Fully type annotated for support with [mypy](https://mypy-lang.org/) and other tooling

so presumably with the annotation the ignore is now in conflict.