coveralls
commented
8 months ago Pull Request Test Coverage Report for Build 7747395463
- 11 of 11 (100.0%) changed or added relevant lines in 4 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.03%) to 86.778%
| Totals | |
|---|---|
| Change from base Build 7745329021: | 0.03% |
| Covered Lines: | 8788 |
| Relevant Lines: | 10127 |
Summary
Closes #1314 Closes #1324
Details and comments
I updated the code to import the
parallel_mapinto qiskit_nature.utils and expose it as_parallel_mapto avoid creating a new public method as such. The import tries in the new location, which exists from 0.46 and above, before it goes back to the former location. The former location still exists in 0.46 but raises a deprecation warning hence the order of trying the imports to avoid this.We could update the min requirements of Qiskit to 0.46 to avoid this and directly import/use parallel map from the new location. I chose the path of broader compatibility and did not update requirements as 0.46 is not quite yet released.
I completely removed TextProgressBar usage as TextProgressBar is removed in 1.0.
Tests all pass locally on my machine where I have the main branch with what will end up in 1.0 installed. It also works with 0.45 as I tried that too as that s currently what CI is using until a newer version gets released. Update: 0.46 has since been released, nightly CI is now failing.
As parallel map is internal logic that was changed, and TextProgressBar just affects what comes out in logs if enabled, neither change warrants a release note I think, so I did not include any.