qiskit-community / qiskit-nature

Qiskit Nature is an open-source, quantum computing, framework for solving quantum mechanical natural science problems.
https://qiskit-community.github.io/qiskit-nature/
Apache License 2.0
306 stars 207 forks source link

Add a new SAOOVQE solver #1364

Open MartinBeseda opened 5 months ago

MartinBeseda commented 5 months ago

I'm writing here with a question, as I'd like to submit a contribution to Qiskit Nature in the form of a new State-Averaged Orbital-Optimized VQE, containing also some new approach to orbital diabatization etc. But, as it is quite a large code, I didn't want to open a PR right away, as I'd like to ask, how should I proceed...

If I do understand the Nature's structure correctly, should we start with including it into second_q/algorithms/excited_states_solvers?

The repository of the whole code is here: https://gitlab.com/MartinBeseda/sa-oo-vqe-qiskit And the documentation is online here: https://sa-oo-vqe-qiskit.readthedocs.io/en/latest/index.html

P.s.: Yes, I've read the contributing guidelines, we'll supplement CLAs, etc. right with the submission.

Thank you very much for all the opinions and advice!

MartinBeseda commented 4 months ago

@mrossinek Do you think it could be of interest to add our solver? Thank you for the info!