qiskit-community / qiskit-optimization

Quantum Optimization
https://qiskit-community.github.io/qiskit-optimization/
Apache License 2.0
230 stars 141 forks source link

Pin qiskit<1.0 #609

Closed t-imamichi closed 9 months ago

t-imamichi commented 9 months ago

Summary

CI fails with Qiskit 1.0. https://github.com/qiskit-community/qiskit-optimization/actions/runs/7924881956 This PR is a workaround until qiskit-algorithms 0.3.0 is released. I locally confirmed that qiskit-optimization main + qiskit-algorithms main + qiskit 1.0 pass all tests. More specifically, we need https://github.com/qiskit-community/qiskit-algorithms/pull/98.

Details and comments

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 7925995792

Details


Totals Coverage Status
Change from base Build 7919898751: 0.0%
Covered Lines: 4511
Relevant Lines: 4849

💛 - Coveralls
woodsp-ibm commented 9 months ago

@t-imamichi So a question. I just fixed up tutorials for the algorithms as CI was failing there qiskit-community/qiskit-algorithms#156. Yesterday in Finance a backport failed, it was done just after 1.0 released where the original PR was done with 0.46, and I just fixed them the same way - CI is now failing there the same way as here, now that the tutorials get further qiskit-community/qiskit-finance#331. I need to fix the tutorials here too and that needs backporting - and that would fail unless this is backported too or we just leave that failing on stable for now. The question is do you just want to wait until algorithms is released so this does not have to be merged on main and then reverted in a couple of days.

woodsp-ibm commented 9 months ago

@t-imamichi Qiskit Algorithms 0.3.0 has been released so this pinning is no longer needed. The PR fixing the tutorials #610 is now passing, except for test of the stable tutorials which 610 is needed to be backported to fix.

woodsp-ibm commented 9 months ago

I am going to close this off since its no longer needed, now that Qiskit Algorithms 0.3.0 has been released.

t-imamichi commented 9 months ago

Thank you for releasing qiskit-algorithms 0.3.0!