Solving a bug in the MaxCut class - Githubissues

qiskit-community / qiskit-optimization

Quantum Optimization

https://qiskit-community.github.io/qiskit-optimization/

Apache License 2.0

230 stars 141 forks source link

Solving a bug in the MaxCut class #611

Open Maldini32 opened 9 months ago

Maldini32 commented 9 months ago

Environment

Qiskit Optimization version: 0.45.1
Python version: 3.10
Operating system: Windows 10

What is happening?

The problem regards the method parse_gset_format, which should be updated in order to correctly read the files.

While in the library version we can find this content in lines 117 to 120:

s__, t__, _ = v
s__ -= 1  # adjust 1-index
t__ -= 1  # ditto
w[s__, t__] = t__

They should be replace with these lines in order to properly assign the weight to the edges:

s__, t__, _ = v
s__ -= 1  # adjust 1-index
t__ -= 1  # ditto
w[s__, t__] = _

How can we reproduce the issue?

The problem is solved by modifying the 120 to:

w[s__, t__] = _

What should happen?

By modifying this line the weights will be correctly assigned to the problem instance.

Any suggestions?

No response

MiasWuQG commented 2 months ago

Thank you for identifying this issue and providing a detailed explanation of the required changes. To help resolve this more efficiently, please consider submitting a Pull Request (PR) with your suggested code modifications. This will allow us to review, test, and merge the fix quickly. Let us know if you need any assistance with the PR process!